NFSv4: Fix error handling in nfs4_sp4_select_mode()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 2 Aug 2018 05:42:04 +0000 (05:42 +0000)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Wed, 8 Aug 2018 20:50:31 +0000 (16:50 -0400)
Error code is set in the error handling cases but never used. Fix it.

Fixes: 937e3133cd0b ("NFSv4.1: Ensure we clear the SP4_MACH_CRED flags in nfs4_sp4_select_mode()")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/nfs4proc.c

index 68788f022461560ace74dd4cb1f6a7e7dfb0d30c..124a9f97c36683dbb273c0a5eff7eb7f784155ae 100644 (file)
@@ -7793,7 +7793,7 @@ static int nfs4_sp4_select_mode(struct nfs_client *clp,
        }
 out:
        clp->cl_sp4_flags = flags;
-       return 0;
+       return ret;
 }
 
 struct nfs41_exchange_id_data {