riscv: add missing newlines to printk messages
authorJohan Hovold <johan@kernel.org>
Fri, 18 Jan 2019 14:03:04 +0000 (15:03 +0100)
committerPalmer Dabbelt <palmer@sifive.com>
Mon, 11 Feb 2019 23:34:56 +0000 (15:34 -0800)
Add missing newline characters to printk messages.

Also replace two pr_warning with the shorter pr_warn, and fix up the
tense of one error message while at it.

Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
arch/riscv/kernel/cpu.c
arch/riscv/kernel/cpufeature.c
arch/riscv/kernel/ftrace.c

index f8fa2c63aa897f943f65fa1e233694978528f749..11ba67f010e7304e20c021f58ae7889a1601f27f 100644 (file)
@@ -106,7 +106,7 @@ static void print_isa(struct seq_file *f, const char *orig_isa)
         * a bit of info describing what went wrong.
         */
        if (isa[0] != '\0')
-               pr_info("unsupported ISA \"%s\" in device tree", orig_isa);
+               pr_info("unsupported ISA \"%s\" in device tree\n", orig_isa);
 }
 
 static void print_mmu(struct seq_file *f, const char *mmu_type)
index a6e369edbbd742663dd98d1a465327f8adfbc659..4891fd62b95ec62fbbd83d3a7512403471ff3782 100644 (file)
@@ -50,12 +50,12 @@ void riscv_fill_hwcap(void)
                if (riscv_of_processor_hartid(node) >= 0)
                        break;
        if (!node) {
-               pr_warning("Unable to find \"cpu\" devicetree entry");
+               pr_warn("Unable to find \"cpu\" devicetree entry\n");
                return;
        }
 
        if (of_property_read_string(node, "riscv,isa", &isa)) {
-               pr_warning("Unable to find \"riscv,isa\" devicetree entry");
+               pr_warn("Unable to find \"riscv,isa\" devicetree entry\n");
                of_node_put(node);
                return;
        }
@@ -67,11 +67,11 @@ void riscv_fill_hwcap(void)
        /* We don't support systems with F but without D, so mask those out
         * here. */
        if ((elf_hwcap & COMPAT_HWCAP_ISA_F) && !(elf_hwcap & COMPAT_HWCAP_ISA_D)) {
-               pr_info("This kernel does not support systems with F but not D");
+               pr_info("This kernel does not support systems with F but not D\n");
                elf_hwcap &= ~COMPAT_HWCAP_ISA_F;
        }
 
-       pr_info("elf_hwcap is 0x%lx", elf_hwcap);
+       pr_info("elf_hwcap is 0x%lx\n", elf_hwcap);
 
 #ifdef CONFIG_FPU
        if (elf_hwcap & (COMPAT_HWCAP_ISA_F | COMPAT_HWCAP_ISA_D))
index a840b7d074f7d3028bb04f7d10e849db68c08c06..b94d8db5ddccbcac050da196c59c926a738894dc 100644 (file)
@@ -32,7 +32,7 @@ static int ftrace_check_current_call(unsigned long hook_pos,
         * return must be -EINVAL on failed comparison
         */
        if (memcmp(expected, replaced, sizeof(replaced))) {
-               pr_err("%p: expected (%08x %08x) but get (%08x %08x)",
+               pr_err("%p: expected (%08x %08x) but got (%08x %08x)\n",
                       (void *)hook_pos, expected[0], expected[1], replaced[0],
                       replaced[1]);
                return -EINVAL;