luci-app-commands: correctly pass custom arguments as query string
authorDaniel Nilsson <dannil+github@protonmail.com>
Wed, 18 Sep 2024 19:37:16 +0000 (21:37 +0200)
committerPaul Donald <newtwen+github@gmail.com>
Wed, 18 Sep 2024 21:24:03 +0000 (23:24 +0200)
Commit 702c007 changed the request to be invoked via the Request.get function
instead of the deprecated XHR one. The request options object requires the
query string to be located inside of the subobject "query", otherwise they are
not picked up. This resulted in breaking the custom arguments functionality as
the input would simply be ignored.

Fixes #7255

Signed-off-by: Daniel Nilsson <dannil+github@protonmail.com>
applications/luci-app-commands/ucode/template/commands.ut

index 90a3c298f0d9b5a218ea4bddf0f579163f9bcd4c..18e3a9dfdaa3a1b8feb95d2831decb93a97921ee 100644 (file)
@@ -45,7 +45,8 @@
                        legend.parentNode.style.display = 'block';
                        legend.style.display = 'inline';
 
-                       L.Request.get(L.url('admin/system/commands/run', id), field ? { args: field.value } : null).then(function(reply) {
+                       var options = field ? { query: { args: field.value } } : null;
+                       L.Request.get(L.url('admin/system/commands/run', id), options).then(function(reply) {
                                var st = reply.json();
 
                                if (st.binary)