staging: comedi: comedi_fops: use kzalloc in comedi_alloc_subdevice_minor()
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Wed, 19 Dec 2012 22:45:34 +0000 (15:45 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Jan 2013 22:25:49 +0000 (14:25 -0800)
The hardware_device member of comedi_file_info is not set in this
function. Use kzalloc to make sure this pointer does not contain
invalid data.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/comedi_fops.c

index 2826a29479c2f093bd171597dcdf653a27ea8a7c..dda47b161bcfcfee9d2b1d67770ed5da2cfebc8e 100644 (file)
@@ -2376,8 +2376,8 @@ int comedi_alloc_subdevice_minor(struct comedi_device *dev,
        struct device *csdev;
        unsigned i;
 
-       info = kmalloc(sizeof(*info), GFP_KERNEL);
-       if (info == NULL)
+       info = kzalloc(sizeof(*info), GFP_KERNEL);
+       if (!info)
                return -ENOMEM;
        info->device = dev;
        info->read_subdevice = s;