ASoC: SOF: Intel: hda: allow operation without i915 gfx

Add support to configure the HDA controller with an external HDA
codec even if iDisp codec in i915 is not available.

This can happen for multiple reasons:
 - internal graphics is disabled on the system
 - i915 driver is not enabled in kernel or it fails to init
 - i915 codec reports error in HDA codec probe
 - HDA codec driver probe fails

Address all these scenarios, but keep using the existing topology.
In case failures occur, HDMI PCM nodes are created, but they will
report error if application tries to use them. No ALSA mixer controls
are created. If the external HDA codec init fails as well, SOF probe
will return error as before.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: https://github.com/thesofproject/linux/issues/1658
Link: https://lore.kernel.org/r/20200220171028.22023-3-kai.vehmanen@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/sof/intel/hda-codec.c b/sound/soc/sof/intel/hda-codec.c
index ff45075ef7203809acb355a6f6c6b028e9daf94f..3041fbbb010a2269e2106a45e0f77ab35c66918b 100644 (file)
--- a/sound/soc/sof/intel/hda-codec.c
+++ b/sound/soc/sof/intel/hda-codec.c
@@ -113,8 +113,14 @@ static int hda_codec_probe(struct snd_sof_dev *sdev, int address,
        if (ret < 0)
                return ret;
 
-       if ((resp & 0xFFFF0000) == IDISP_VID_INTEL)
+       if ((resp & 0xFFFF0000) == IDISP_VID_INTEL) {
+               if (!hdev->bus->audio_component) {
+                       dev_dbg(sdev->dev,
+                               "iDisp hw present but no driver\n");
+                       return -ENOENT;
+               }
                hda_priv->need_display_power = true;
+       }
 
        /*
         * if common HDMI codec driver is not used, codec load
@@ -203,6 +209,9 @@ int hda_codec_i915_exit(struct snd_sof_dev *sdev)
        struct hdac_bus *bus = sof_to_bus(sdev);
        int ret;
 
+       if (!bus->audio_component)
+               return 0;
+
        /* power down unconditionally */
        snd_hdac_display_power(bus, HDA_CODEC_IDX_CONTROLLER, false);
 

diff --git a/sound/soc/sof/intel/hda.c b/sound/soc/sof/intel/hda.c
index 726a9ef2d627f54dce25e032e2c881286fa0a06d..7ca887041a3441e616d723aa08e4e26d72a10c61 100644 (file)
--- a/sound/soc/sof/intel/hda.c
+++ b/sound/soc/sof/intel/hda.c
@@ -288,10 +288,8 @@ static int hda_init(struct snd_sof_dev *sdev)
 
        /* init i915 and HDMI codecs */
        ret = hda_codec_i915_init(sdev);
-       if (ret < 0) {
-               dev_err(sdev->dev, "error: init i915 and HDMI codec failed\n");
-               return ret;
-       }
+       if (ret < 0)
+               dev_warn(sdev->dev, "init of i915 and HDMI codec failed\n");
 
        /* get controller capabilities */
        ret = hda_dsp_ctrl_get_caps(sdev);
@@ -365,9 +363,6 @@ static int hda_init_caps(struct snd_sof_dev *sdev)
        if (ret < 0) {
                dev_err(bus->dev, "error: init chip failed with ret: %d\n",
                        ret);
-#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA)
-               hda_codec_i915_exit(sdev);
-#endif
                return ret;
        }
 
@@ -379,7 +374,7 @@ static int hda_init_caps(struct snd_sof_dev *sdev)
        hda_codec_probe_bus(sdev, hda_codec_use_common_hdmi);
 
        if (!HDA_IDISP_CODEC(bus->codec_mask))
-               hda_codec_i915_exit(sdev);
+               hda_codec_i915_display_power(sdev, false);
 
        /*
         * we are done probing so decrement link counts
@@ -699,12 +694,11 @@ static int hda_generic_machine_select(struct snd_sof_dev *sdev)
                /*
                 * If no machine driver is found, then:
                 *
-                * hda machine driver is used if :
-                * 1. there is one HDMI codec and one external HDAudio codec
-                * 2. only HDMI codec
+                * generic hda machine driver can handle:
+                *  - one HDMI codec, and/or
+                *  - one external HDAudio codec
                 */
-               if (!pdata->machine && codec_num <= 2 &&
-                   HDA_IDISP_CODEC(bus->codec_mask)) {
+               if (!pdata->machine && codec_num <= 2) {
                        hda_mach = snd_soc_acpi_intel_hda_machines;
 
                        /* topology: use the info from hda_machines */
@@ -714,7 +708,7 @@ static int hda_generic_machine_select(struct snd_sof_dev *sdev)
                        dev_info(bus->dev, "using HDA machine driver %s now\n",
                                 hda_mach->drv_name);
 
-                       if (codec_num == 1)
+                       if (codec_num == 1 && HDA_IDISP_CODEC(bus->codec_mask))
                                idisp_str = "-idisp";
                        else
                                idisp_str = "";