tools lib bpf: Fix compiler warning on CentOS 6
authorNamhyung Kim <namhyung@kernel.org>
Tue, 3 Nov 2015 11:21:05 +0000 (20:21 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 3 Nov 2015 15:13:31 +0000 (12:13 -0300)
    CC       libbpf.o
  cc1: warnings being treated as errors
  libbpf.c: In function 'bpf_program__title':
  libbpf.c:1037: error: declaration of 'dup' shadows a global declaration
  /usr/include/unistd.h:528: error: shadowed declaration is here
  mv: cannot stat `./.libbpf.o.tmp': No such file or directory
  make[3]: *** [libbpf.o] Error 1
  make[2]: *** [libbpf-in.o] Error 2
  make[1]: *** [/linux/tools/lib/bpf/libbpf.a] Error 2
  make[1]: *** Waiting for unfinished jobs....

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1446549665-2342-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/lib/bpf/libbpf.c
tools/lib/bpf/libbpf.h

index 4252fc22f78f4f8fd4c204975b5464f5bbc192e0..9f3c8cf9249b6d2e9cb87629f8a26237f98e2027 100644 (file)
@@ -1034,12 +1034,12 @@ int bpf_program__get_private(struct bpf_program *prog, void **ppriv)
        return 0;
 }
 
-const char *bpf_program__title(struct bpf_program *prog, bool dup)
+const char *bpf_program__title(struct bpf_program *prog, bool needs_copy)
 {
        const char *title;
 
        title = prog->section_name;
-       if (dup) {
+       if (needs_copy) {
                title = strdup(title);
                if (!title) {
                        pr_warning("failed to strdup program title\n");
index f16170c95ffdc2306aa02f836092661b2673408e..bc80af03c6f41b5ff976aa2124cc6c25dc6f021a 100644 (file)
@@ -63,7 +63,7 @@ int bpf_program__set_private(struct bpf_program *prog, void *priv,
 int bpf_program__get_private(struct bpf_program *prog,
                             void **ppriv);
 
-const char *bpf_program__title(struct bpf_program *prog, bool dup);
+const char *bpf_program__title(struct bpf_program *prog, bool needs_copy);
 
 int bpf_program__fd(struct bpf_program *prog);