cpufreq: exynos5440: Protect OPP search calls with RCU lock
authorAmit Daniel Kachhap <amit.daniel@samsung.com>
Sun, 21 Apr 2013 22:24:37 +0000 (00:24 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sun, 21 Apr 2013 22:24:37 +0000 (00:24 +0200)
As per the OPP library documentation(Documentation/power/opp.txt) all
OPP find/get calls should be protected by RCU locks.

Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/exynos5440-cpufreq.c

index ead7ed43e2389d9008aa92bdfd1dd832c27b48f4..0c74018eda47e1fd2d09ef0db1baaf8595a70547 100644 (file)
@@ -120,11 +120,13 @@ static int init_div_table(void)
        int i = 0;
        struct opp *opp;
 
+       rcu_read_lock();
        for (i = 0; freq_tbl[i].frequency != CPUFREQ_TABLE_END; i++) {
 
                opp = opp_find_freq_exact(dvfs_info->dev,
                                        freq_tbl[i].frequency * 1000, true);
                if (IS_ERR(opp)) {
+                       rcu_read_unlock();
                        dev_err(dvfs_info->dev,
                                "failed to find valid OPP for %u KHZ\n",
                                freq_tbl[i].frequency);
@@ -159,6 +161,7 @@ static int init_div_table(void)
                __raw_writel(tmp, dvfs_info->base + XMU_PMU_P0_7 + 4 * i);
        }
 
+       rcu_read_unlock();
        return 0;
 }