net/ipv6: don't reinitialize ndev->cnf.addr_gen_mode on new inet6_dev
authorSabrina Dubroca <sd@queasysnail.net>
Mon, 9 Jul 2018 10:25:15 +0000 (12:25 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 12 Jul 2018 05:50:45 +0000 (22:50 -0700)
The value has already been copied from this netns's devconf_dflt, it
shouldn't be reset to the global kernel default.

Fixes: d35a00b8e33d ("net/ipv6: allow sysctl to change link-local address generation mode")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/addrconf.c

index e9ba53d2a147b5a6715c024a90a9540b0bb93167..e20f8a1d8cdbbe88cceb884ebd5de3a1f603dd4f 100644 (file)
@@ -385,8 +385,6 @@ static struct inet6_dev *ipv6_add_dev(struct net_device *dev)
 
        if (ndev->cnf.stable_secret.initialized)
                ndev->cnf.addr_gen_mode = IN6_ADDR_GEN_MODE_STABLE_PRIVACY;
-       else
-               ndev->cnf.addr_gen_mode = ipv6_devconf_dflt.addr_gen_mode;
 
        ndev->cnf.mtu6 = dev->mtu;
        ndev->nd_parms = neigh_parms_alloc(dev, &nd_tbl);