luci-base: widgets; remove maximal firewall zone name length datatype
authorPaul Donald <newtwen+github@gmail.com>
Tue, 14 Jan 2025 15:16:56 +0000 (16:16 +0100)
committerPaul Donald <newtwen+github@gmail.com>
Tue, 14 Jan 2025 15:16:56 +0000 (16:16 +0100)
removes a075566dbb5147a4311cd24f46a173222c9172cf (and subsequent fixes)

enforcing a datatype on this widget generates the following error when
multiple zones are selected:

 Expecting: valid UCI identifier

(the error triggered for uciname). At its simplest: multiple selections
are no longer just a uciname, but multiple thereof.

Signed-off-by: Paul Donald <newtwen+github@gmail.com>
modules/luci-base/htdocs/luci-static/resources/tools/widgets.js

index cd16227fc8299784563bbca0b50e88a2dc1fdb50..0ba07afcde8acd848d60b0b5b6df91d5d8da3602 100644 (file)
@@ -148,7 +148,6 @@ var CBIZoneSelect = form.ListValue.extend({
                        display_items: this.display_size || this.size || 3,
                        dropdown_items: this.dropdown_size || this.size || 5,
                        validate: L.bind(this.validate, this, section_id),
-                       datatype: L.hasSystemFeature('firewall4') ? 'uciname' : 'and(uciname,maxlength(11))',
                        create: !this.nocreate,
                        create_markup: '' +
                                '<li data-value="{{value}}">' +