iio: adc: ad7280a: Fix memory leak
authorMichael Hennerich <michael.hennerich@analog.com>
Wed, 26 Oct 2011 11:38:18 +0000 (13:38 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sun, 27 Nov 2011 00:28:56 +0000 (16:28 -0800)
Free channels in case read fails with error.

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/iio/adc/ad7280a.c

index 0c212e050a8dfa788f0dfa0da8340c7d17cd3427..f45b66bf6105335cb9f2631554d74b751a392511 100644 (file)
@@ -688,7 +688,7 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
 
        ret = ad7280_read_all_channels(st, st->scan_cnt, channels);
        if (ret < 0)
-               return IRQ_HANDLED;
+               goto out;
 
        for (i = 0; i < st->scan_cnt; i++) {
                if (((channels[i] >> 23) & 0xF) <= AD7280A_CELL_VOLTAGE_6) {
@@ -731,6 +731,7 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
                }
        }
 
+out:
        kfree(channels);
 
        return IRQ_HANDLED;