drm/nouveau: Add size to vbios.rom file in debugfs
authorLyude Paul <lyude@redhat.com>
Wed, 19 Sep 2018 17:13:52 +0000 (13:13 -0400)
committerBen Skeggs <bskeggs@redhat.com>
Tue, 11 Dec 2018 05:37:09 +0000 (15:37 +1000)
With this, nvbios /sys/kernel/debug/dri/*/vbios.rom now works!

Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
drivers/gpu/drm/nouveau/nouveau_debugfs.c

index 7379c20584a2342cbbf7e81968bc4319fe49d9bf..88a52f6b39fe333df24c33dce9aef2535d6a1b09 100644 (file)
@@ -220,8 +220,9 @@ static const struct nouveau_debugfs_files {
 int
 nouveau_drm_debugfs_init(struct drm_minor *minor)
 {
+       struct nouveau_drm *drm = nouveau_drm(minor->dev);
        struct dentry *dentry;
-       int i;
+       int i, ret;
 
        for (i = 0; i < ARRAY_SIZE(nouveau_debugfs_files); i++) {
                dentry = debugfs_create_file(nouveau_debugfs_files[i].name,
@@ -232,9 +233,23 @@ nouveau_drm_debugfs_init(struct drm_minor *minor)
                        return -ENOMEM;
        }
 
-       return drm_debugfs_create_files(nouveau_debugfs_list,
-                                       NOUVEAU_DEBUGFS_ENTRIES,
-                                       minor->debugfs_root, minor);
+       ret = drm_debugfs_create_files(nouveau_debugfs_list,
+                                      NOUVEAU_DEBUGFS_ENTRIES,
+                                      minor->debugfs_root, minor);
+       if (ret)
+               return ret;
+
+       /* Set the size of the vbios since we know it, and it's confusing to
+        * userspace if it wants to seek() but the file has a length of 0
+        */
+       dentry = debugfs_lookup("vbios.rom", minor->debugfs_root);
+       if (!dentry)
+               return 0;
+
+       d_inode(dentry)->i_size = drm->vbios.length;
+       dput(dentry);
+
+       return 0;
 }
 
 int