luci.js: remove unsafe fallback code from dom.parse()
authorJo-Philipp Wich <jo@mein.io>
Thu, 23 Dec 2021 16:09:13 +0000 (17:09 +0100)
committerJo-Philipp Wich <jo@mein.io>
Thu, 23 Dec 2021 16:10:33 +0000 (17:10 +0100)
Do not fallback to .innerHTML if DOMParser() failed for whatever reason.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 63d9bcb6825fac92fd7dfa4ba858c8d5aafa23e8)

modules/luci-base/htdocs/luci-static/resources/luci.js

index c0e8b15a56ba50ce05f9efb8ab11d046619723c5..8f8b9673d64aeef00ea2f9bd31b00b68360d6840 100644 (file)
                 * `null` on parsing failures or if no element could be found.
                 */
                parse: function(s) {
-                       var elem;
+                       var elem = null;
 
                        try {
                                domParser = domParser || new DOMParser();
                        }
                        catch(e) {}
 
-                       if (!elem) {
-                               try {
-                                       dummyElem = dummyElem || document.createElement('div');
-                                       dummyElem.innerHTML = s;
-                                       elem = dummyElem.firstChild;
-                               }
-                               catch (e) {}
-                       }
-
-                       return elem || null;
+                       return elem;
                },
 
                /**