8021q: fix vlan device to inherit the unicast filtering capability flag
authorYi Zou <yi.zou@intel.com>
Wed, 28 Nov 2012 13:45:24 +0000 (13:45 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 Nov 2012 17:07:27 +0000 (12:07 -0500)
This bug is observed on running FCoE over a VLAN device associated w/
a real device that has IFF_UNICAST_FLT set since FCoE would add unicast
address such as FLOGI MAC to the VLAN interface that FCoE is on. Since
currently, VLAN device is not inheriting the IFF_UNICAST_FLT flag from the
parent real device even though the real device is capable of doing unicast
filtering. This forces the VLAN device and its real device go to promiscuous
mode unnecessarily even the added address is actually being added to the
available unicast filter table in real device.

Signed-off-by: Yi Zou <yi.zou@intel.com>
Cc: devel@open-fcoe.org
Signed-off-by: David S. Miller <davem@davemloft.net>
net/8021q/vlan.c

index afba51e6031060fe634a5af39cb4b5fcff2e8d36..a292e8050ef234029611090004f1b46f889610d3 100644 (file)
@@ -242,6 +242,7 @@ static int register_vlan_device(struct net_device *real_dev, u16 vlan_id)
         * hope the underlying device can handle it.
         */
        new_dev->mtu = real_dev->mtu;
+       new_dev->priv_flags |= (real_dev->priv_flags & IFF_UNICAST_FLT);
 
        vlan_dev_priv(new_dev)->vlan_id = vlan_id;
        vlan_dev_priv(new_dev)->real_dev = real_dev;