cli: static keyword tweak

Function ubus_cli_listen() is called only once, and function uloop_run()
and uloop_done() which need struct ubus_event_handler listener are
called within this function, so it's not needed to mark struct
ubus_event_handler listener as static. The same as pointer struct
ubus_context *ctx in main function.

Global struct commands is only used in this file, so it should be marked
static.

Signed-off-by: Zhao, Gang <gang.zhao.42@gmail.com>

diff --git a/cli.c b/cli.c
index 98fc4fedecb8132ec49ec74a54e49d5242f8289c..eea43e38aa8d8da7c38af4e6131a7218c6a72f71 100644 (file)
--- a/cli.c
+++ b/cli.c
@@ -142,7 +142,7 @@ static int ubus_cli_call(struct ubus_context *ctx, int argc, char **argv)
 
 static int ubus_cli_listen(struct ubus_context *ctx, int argc, char **argv)
 {
-       static struct ubus_event_handler listener;
+       struct ubus_event_handler listener;
        const char *event;
        int ret = 0;
 
@@ -479,7 +479,7 @@ static int usage(const char *prog)
 }
 
 
-struct {
+static struct {
        const char *name;
        int (*cb)(struct ubus_context *ctx, int argc, char **argv);
 } commands[] = {
@@ -494,7 +494,7 @@ struct {
 int main(int argc, char **argv)
 {
        const char *progname, *ubus_socket = NULL;
-       static struct ubus_context *ctx;
+       struct ubus_context *ctx;
        char *cmd;
        int ret = 0;
        int i, ch;