serial: omap: don't save IRQ flags on hardirq

When we're running our hardirq handler, there's
not need to disable IRQs with spin_lock_irqsave()
because IRQs are already disabled. It also makes
no difference if we save or not IRQ flags.

Switch over to simple spin_lock/spin_unlock and
drop the "flags" variable.

Tested-by: Shubhrajyoti D <shubhrajyoti@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 0ceca4457d3bdcb42a88a19eb131d9bf4d675330..99042b0fb9410f0eb3fc0c28a9b69ac50c7104c4 100644 (file)
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -351,11 +351,10 @@ static inline irqreturn_t serial_omap_irq(int irq, void *dev_id)
        struct tty_struct *tty = up->port.state->port.tty;
        unsigned int iir, lsr;
        unsigned int type;
-       unsigned long flags;
        irqreturn_t ret = IRQ_NONE;
        int max_count = 256;
 
-       spin_lock_irqsave(&up->port.lock, flags);
+       spin_lock(&up->port.lock);
        pm_runtime_get_sync(up->dev);
 
        do {
@@ -394,7 +393,7 @@ static inline irqreturn_t serial_omap_irq(int irq, void *dev_id)
                }
        } while (!(iir & UART_IIR_NO_INT) && max_count--);
 
-       spin_unlock_irqrestore(&up->port.lock, flags);
+       spin_unlock(&up->port.lock);
 
        tty_flip_buffer_push(tty);