net_sched: sch_fq: avoid calling ktime_get_ns() if not needed
authorEric Dumazet <edumazet@google.com>
Tue, 20 Nov 2018 01:30:19 +0000 (17:30 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 20 Nov 2018 17:51:32 +0000 (09:51 -0800)
There are two cases were we can avoid calling ktime_get_ns() :

1) Queue is empty.
2) Internal queue is not empty.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_fq.c

index 1da8864502d448cfa93a9c02da504af61a1093e5..1a662f2bb7bb7bb5507107f61657d44fa28ca991 100644 (file)
@@ -414,16 +414,21 @@ static void fq_check_throttled(struct fq_sched_data *q, u64 now)
 static struct sk_buff *fq_dequeue(struct Qdisc *sch)
 {
        struct fq_sched_data *q = qdisc_priv(sch);
-       u64 now = ktime_get_ns();
        struct fq_flow_head *head;
        struct sk_buff *skb;
        struct fq_flow *f;
        unsigned long rate;
        u32 plen;
+       u64 now;
+
+       if (!sch->q.qlen)
+               return NULL;
 
        skb = fq_dequeue_head(sch, &q->internal);
        if (skb)
                goto out;
+
+       now = ktime_get_ns();
        fq_check_throttled(q, now);
 begin:
        head = &q->new_flows;