ncm: Remove unnecessary proto_set_available commands
authorJohn Crispin <john@openwrt.org>
Mon, 9 Mar 2015 14:06:50 +0000 (14:06 +0000)
committerJohn Crispin <john@openwrt.org>
Mon, 9 Mar 2015 14:06:50 +0000 (14:06 +0000)
Interface should not be set unavailable in all error cases,
returning 1 is enough.

Signed-off-by: Matti Laakso <malaakso@elisanet.fi>
SVN-Revision: 44630

package/network/utils/comgt/files/ncm.sh

index 2c2835fe3947485ed48254047bf970797898a822..4c3f161f98a5c33d34b69b7713740a638e286fc3 100644 (file)
@@ -41,7 +41,6 @@ proto_ncm_setup() {
        [ -n "$apn" ] || {
                echo "No APN specified"
                proto_notify_error "$interface" NO_APN
-               proto_set_available "$interface" 0
                return 1
        }
 
@@ -69,7 +68,6 @@ proto_ncm_setup() {
        [ $? -ne 0 ] && {
                echo "Failed to get modem information"
                proto_notify_error "$interface" GETINFO_FAILED
-               proto_set_available "$interface" 0
                return 1
        }
 
@@ -86,7 +84,6 @@ proto_ncm_setup() {
                eval COMMAND="$i" gcom -d "$device" -s /etc/gcom/runcommand.gcom || {
                        echo "Failed to initialize modem"
                        proto_notify_error "$interface" INITIALIZE_FAILED
-                       proto_set_available "$interface" 0
                        return 1
                }
        done
@@ -105,7 +102,6 @@ proto_ncm_setup() {
                COMMAND="$setmode" gcom -d "$device" -s /etc/gcom/runcommand.gcom || {
                        echo "Failed to set operating mode"
                        proto_notify_error "$interface" SETMODE_FAILED
-                       proto_set_available "$interface" 0
                        return 1
                }
                json_select ..
@@ -115,7 +111,6 @@ proto_ncm_setup() {
        eval COMMAND="$connect" gcom -d "$device" -s /etc/gcom/runcommand.gcom || {
                echo "Failed to connect"
                proto_notify_error "$interface" CONNECT_FAILED
-               proto_set_available "$interface" 0
                return 1
        }