drm/i915: remove stale comment from sanitize_encoder
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 21 Nov 2017 09:42:41 +0000 (10:42 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 23 Nov 2017 13:59:07 +0000 (14:59 +0100)
This goes back to pre-atomic, where due to intermediate dpms states
connectors and encoder states might indeed not have matched.

With atomic that's all smashed together (and hopefully no bios ever
enables a vga output in dpms standby/suspedn state or we're toast).
In

commit 873ffe69a9097fb241fff2967ea6f0bf2c179195
Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Date:   Wed Aug 5 12:37:07 2015 +0200

    drm/i915: Remove connectors_active from sanitization, v2.

sanitize_encoders was changed to disable the encoder in all cases,
which made the comment obsolete.

Remove the misleading comment.

Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171121094241.9129-1-daniel.vetter@ffwll.ch
drivers/gpu/drm/i915/intel_display.c

index 5ca7b33554ef433f181f9cd92ed6a7cdcdcfc36b..fec267dfc06230f10fe483cb25076b0098b1e240 100644 (file)
@@ -14909,8 +14909,6 @@ static void intel_sanitize_encoder(struct intel_encoder *encoder)
                connector->base.dpms = DRM_MODE_DPMS_OFF;
                connector->base.encoder = NULL;
        }
-       /* Enabled encoders without active connectors will be fixed in
-        * the crtc fixup. */
 }
 
 void i915_redisable_vga_power_on(struct drm_i915_private *dev_priv)