drm/i915/tv: Fix return value for intel_tv_compute_config()
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 25 Jan 2019 18:19:30 +0000 (20:19 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 28 Jan 2019 13:53:32 +0000 (15:53 +0200)
Ever since commit 204474a6b859 ("drm/i915: Pass down rc in
intel_encoder->compute_config()") we're supposed to return an
errno from .compute_config(). I failed to notice that when
pushing the TV encoder fixes which were written before said
commmit. Fix up the return value for the error case.

Cc: Imre Deak <imre.deak@intel.com>
Fixes: 690157f0a9e7 ("drm/i915/tv: Fix >1024 modes on gen3")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190125181931.19482-1-ville.syrjala@linux.intel.com
Reviewed-by: Imre Deak <imre.deak@intel.com>
drivers/gpu/drm/i915/intel_tv.c

index f0b9abda7720d3a5734854e8bafa85a0c361f660..78be08e2971ba8689afaf1d0667bbcee956ed987 100644 (file)
@@ -1189,7 +1189,7 @@ intel_tv_compute_config(struct intel_encoder *encoder,
 
                if (extra < 0) {
                        DRM_DEBUG_KMS("No vertical scaling for >1024 pixel wide modes\n");
-                       return false;
+                       return -EINVAL;
                }
 
                /* Need to turn off the vertical filter and center the image */