drm/amdgpu: remove VM shadow WARN_ONs
authorAlex Deucher <alexander.deucher@amd.com>
Thu, 13 Jul 2017 19:37:11 +0000 (15:37 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 14 Jul 2017 15:06:43 +0000 (11:06 -0400)
Printing a warning into the logs that we will certainly run into a BUG() is
completely nonsense, the BUG() is more than noisy enough.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

index db9f12e85fb49cc8e1602de6822caf3dab455513..74cbe10a01158a9c65cd0476486b683c894ae228 100644 (file)
@@ -1044,8 +1044,7 @@ static int amdgpu_vm_update_level(struct amdgpu_device *adev,
        params.adev = adev;
        shadow = parent->bo->shadow;
 
-       WARN_ON(vm->use_cpu_for_update && shadow);
-       if (vm->use_cpu_for_update && !shadow) {
+       if (vm->use_cpu_for_update) {
                r = amdgpu_bo_kmap(parent->bo, (void **)&pd_addr);
                if (r)
                        return r;
@@ -1310,9 +1309,6 @@ static int amdgpu_vm_update_ptes(struct amdgpu_pte_update_params *params,
                        r = amdgpu_bo_kmap(pt, (void *)&pe_start);
                        if (r)
                                return r;
-
-                       WARN_ONCE(pt->shadow,
-                                 "CPU VM update doesn't support shadow pages");
                } else {
                        if (pt->shadow) {
                                pe_start = amdgpu_bo_gpu_offset(pt->shadow);