powerpc/pseries/cmm: Cleanup rc handling in cmm_init()
authorDavid Hildenbrand <david@redhat.com>
Thu, 31 Oct 2019 14:29:24 +0000 (15:29 +0100)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 13 Nov 2019 05:58:00 +0000 (16:58 +1100)
No need to initialize rc. Also, let's return 0 directly when
succeeding.

Signed-off-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20191031142933.10779-4-david@redhat.com
arch/powerpc/platforms/pseries/cmm.c

index fab049d3ea1eae152e637da7a415cc58c6dae460..738eb1681d4055d8d42c3a622e4f3785fde81930 100644 (file)
@@ -669,7 +669,7 @@ static struct notifier_block cmm_mem_nb = {
  **/
 static int cmm_init(void)
 {
-       int rc = -ENOMEM;
+       int rc;
 
        if (!firmware_has_feature(FW_FEATURE_CMO))
                return -EOPNOTSUPP;
@@ -692,7 +692,7 @@ static int cmm_init(void)
                goto out_unregister_notifier;
 
        if (cmm_disabled)
-               return rc;
+               return 0;
 
        cmm_thread_ptr = kthread_run(cmm_thread, NULL, "cmmthread");
        if (IS_ERR(cmm_thread_ptr)) {
@@ -700,8 +700,7 @@ static int cmm_init(void)
                goto out_unregister_notifier;
        }
 
-       return rc;
-
+       return 0;
 out_unregister_notifier:
        unregister_memory_notifier(&cmm_mem_nb);
        unregister_memory_isolate_notifier(&cmm_mem_isolate_nb);