btrfs: Remove fs_info from btrfs_rm_dev_replace_remove_srcdev
authorNikolay Borisov <nborisov@suse.com>
Fri, 20 Jul 2018 16:37:48 +0000 (19:37 +0300)
committerDavid Sterba <dsterba@suse.com>
Mon, 6 Aug 2018 11:12:57 +0000 (13:12 +0200)
It can be referenced from the passed srcdev argument.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/dev-replace.c
fs/btrfs/volumes.c
fs/btrfs/volumes.h

index 059ca3d5ddd3b40aa8d409fe589ac31c308b482a..df375e1a0c9f2aa5244db7574af2cb321017f8f8 100644 (file)
@@ -667,7 +667,7 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info,
 
        btrfs_rm_dev_replace_blocked(fs_info);
 
-       btrfs_rm_dev_replace_remove_srcdev(fs_info, src_device);
+       btrfs_rm_dev_replace_remove_srcdev(src_device);
 
        btrfs_rm_dev_replace_unblocked(fs_info);
 
index 1c88c4c947bb7f5e29a0b45b4d74270cc84cc693..d82658b01773c1d7b120fe3885d05535f895cfbd 100644 (file)
@@ -1996,12 +1996,11 @@ error_undo:
        goto out;
 }
 
-void btrfs_rm_dev_replace_remove_srcdev(struct btrfs_fs_info *fs_info,
-                                       struct btrfs_device *srcdev)
+void btrfs_rm_dev_replace_remove_srcdev(struct btrfs_device *srcdev)
 {
        struct btrfs_fs_devices *fs_devices;
 
-       lockdep_assert_held(&fs_info->fs_devices->device_list_mutex);
+       lockdep_assert_held(&srcdev->fs_info->fs_devices->device_list_mutex);
 
        /*
         * in case of fs with no seed, srcdev->fs_devices will point
index 6943aab9bdd705edad35145559d2817950620bcf..0ae45ff1961b6276e4453b4f742d859ecfa7b777 100644 (file)
@@ -452,8 +452,7 @@ void btrfs_init_devices_late(struct btrfs_fs_info *fs_info);
 int btrfs_init_dev_stats(struct btrfs_fs_info *fs_info);
 int btrfs_run_dev_stats(struct btrfs_trans_handle *trans,
                        struct btrfs_fs_info *fs_info);
-void btrfs_rm_dev_replace_remove_srcdev(struct btrfs_fs_info *fs_info,
-                                       struct btrfs_device *srcdev);
+void btrfs_rm_dev_replace_remove_srcdev(struct btrfs_device *srcdev);
 void btrfs_rm_dev_replace_free_srcdev(struct btrfs_fs_info *fs_info,
                                      struct btrfs_device *srcdev);
 void btrfs_destroy_dev_replace_tgtdev(struct btrfs_fs_info *fs_info,