perf test bpf: Improve message about expected samples
authorArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 2 Jan 2018 17:59:21 +0000 (14:59 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 8 Jan 2018 14:11:56 +0000 (11:11 -0300)
When failing on one of the BPF tests we were just stating:

  BPF filter result incorrect

Add some more info to help figuring out the problem:

 BPF filter result incorrect, expected 56, got 0 samples

This came out while investigating this failure, first seen after
updating the kernel to the 4.15.0-rc6 tag:

  [root@jouet ~]# perf test bpf
  39: BPF filter               :
  39.1: Basic BPF filtering    : FAILED!
  39.2: BPF pinning            : Skip
  39.3: BPF prologue generation: Skip
  39.4: BPF relocation checker : Skip
  [root@jouet ~]#

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: https://lkml.kernel.org/n/tip-403npu7daupv6b2bmxliv5pk@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/bpf.c

index c433dd30975a3b13ff08cc680e8782f30ce54cdf..057c6b8fdb53e7d24fffa871450e2582d1dd4fee 100644 (file)
@@ -190,7 +190,7 @@ static int do_test(struct bpf_object *obj, int (*func)(void),
        }
 
        if (count != expect) {
-               pr_debug("BPF filter result incorrect\n");
+               pr_debug("BPF filter result incorrect, expected %d, got %d samples\n", expect, count);
                goto out_delete_evlist;
        }