drm/amd/display: Fix boolean expression in get_surf_rq_param
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 3 Jan 2019 19:48:45 +0000 (13:48 -0600)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 14 Jan 2019 20:04:50 +0000 (15:04 -0500)
Fix boolean expression by using logical AND operator '&&'
instead of bitwise operator '&'.

This issue was detected with the help of Coccinelle.

Fixes: 6d04ee9dc101 ("drm/amd/display: Restructuring and cleaning up DML")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dml/dml1_display_rq_dlg_calc.c

index a8b233ee5f97e80bdf8a6b0fe779a9d55ca97cc6..ad8571f5a142fb3405d78dd165119f4a2a4a4d3e 100644 (file)
@@ -881,7 +881,7 @@ static void get_surf_rq_param(
        /* the dpte_group_bytes is reduced for the specific case of vertical
         * access of a tile surface that has dpte request of 8x1 ptes.
         */
-       if (!surf_linear & (log2_dpte_req_height_ptes == 0) & surf_vert) /*reduced, in this case, will have page fault within a group */
+       if (!surf_linear && (log2_dpte_req_height_ptes == 0) && surf_vert) /*reduced, in this case, will have page fault within a group */
                rq_sizing_param->dpte_group_bytes = 512;
        else
                /*full size */