media: staging: atomisp: fix string comparation logic
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 6 Apr 2018 18:45:59 +0000 (14:45 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 17 Apr 2018 09:49:58 +0000 (05:49 -0400)
it makes no sense to use strncmp() with a size with is
bigger than the string we're comparing with.

Fix those warnings:

    drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c:776 atomisp_open() error: strncmp() '"ATOMISP ISP ACC"' too small (16 vs 32)
    drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c:913 atomisp_release() error: strncmp() '"ATOMISP ISP ACC"' too small (16 vs 32)
    drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c:2751 atomisp_vidioc_default() error: strncmp() '"ATOMISP ISP ACC"' too small (16 vs 32)

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c
drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c

index 709137f25700807059eddc368bd55a69d5910189..693b905547e435072cb9680e0a8488fa4f27beaa 100644 (file)
@@ -773,8 +773,7 @@ static int atomisp_open(struct file *file)
 
        rt_mutex_lock(&isp->mutex);
 
-       acc_node = !strncmp(vdev->name, "ATOMISP ISP ACC",
-                       sizeof(vdev->name));
+       acc_node = !strcmp(vdev->name, "ATOMISP ISP ACC");
        if (acc_node) {
                acc_pipe = atomisp_to_acc_pipe(vdev);
                asd = acc_pipe->asd;
@@ -910,8 +909,7 @@ static int atomisp_release(struct file *file)
        rt_mutex_lock(&isp->mutex);
 
        dev_dbg(isp->dev, "release device %s\n", vdev->name);
-       acc_node = !strncmp(vdev->name, "ATOMISP ISP ACC",
-                       sizeof(vdev->name));
+       acc_node = !strcmp(vdev->name, "ATOMISP ISP ACC");
        if (acc_node) {
                acc_pipe = atomisp_to_acc_pipe(vdev);
                asd = acc_pipe->asd;
index 6e72312438915f7ab7da645e00c76522e9acb96b..8c67aea67b6b4d389231c648adb76f0bbedabf74 100644 (file)
@@ -2748,8 +2748,7 @@ static long atomisp_vidioc_default(struct file *file, void *fh,
        bool acc_node;
        int err;
 
-       acc_node = !strncmp(vdev->name, "ATOMISP ISP ACC",
-                       sizeof(vdev->name));
+       acc_node = !strcmp(vdev->name, "ATOMISP ISP ACC");
        if (acc_node)
                asd = atomisp_to_acc_pipe(vdev)->asd;
        else