ramips: fix dtc compiler warnings
authorMathias Kresin <dev@kresin.me>
Thu, 6 Dec 2018 09:02:29 +0000 (10:02 +0100)
committerJo-Philipp Wich <jo@mein.io>
Tue, 18 Dec 2018 16:48:23 +0000 (17:48 +0100)
The latest dtc compiler considers nodes named i2c or spi as the
respective bus:

  /pinctrl/i2c: incorrect #address-cells for I2C bus
  /pinctrl/spi: incorrect #address-cells for SPI bus

Rename the node to fix the false positives.

Fix the spi node unit address for the DWR-512-B and UBNT-ER-e50 to get
rid of the following warning:

  SPI bus unit address format error, expected "n"

Signed-off-by: Mathias Kresin <dev@kresin.me>
(backported from ffa55386f17cff29f6c3ffbe873335511e253932)

target/linux/ramips/dts/DWR-512-B.dts
target/linux/ramips/dts/UBNT-ER-e50.dtsi
target/linux/ramips/dts/mt7620a.dtsi
target/linux/ramips/dts/mt7620n.dtsi
target/linux/ramips/dts/mt7621.dtsi
target/linux/ramips/dts/mt7628an.dtsi
target/linux/ramips/dts/rt2880.dtsi
target/linux/ramips/dts/rt3050.dtsi
target/linux/ramips/dts/rt3352.dtsi
target/linux/ramips/dts/rt3883.dtsi
target/linux/ramips/dts/rt5350.dtsi

index d1dc97ff7eef9e4166a07176440ec693e52e72fa..d865ced704b95f553269f8816c264eabf267fb71 100644 (file)
 &spi1 {
        status = "okay";
 
-       spidev@1 {
+       spidev@0 {
                #address-cells = <1>;
                #size-cells = <1>;
                compatible = "siliconlabs,si3210";
index 2a983d08ff384a92c54c30386d7aa85be5445d86..b3949a39f0f8e97469a0c10d2d69560d4fdb1508 100644 (file)
@@ -91,7 +91,7 @@
         */
        status = "disabled";
 
-       m25p80@0 {
+       m25p80@1 {
                compatible = "jedec,spi-nor";
                reg = <1>;
                spi-max-frequency = <10000000>;
index 2d6ec49370ccde71307bc039b676c7ee380c6b70..150c0e14ca2d1c3f4bf8f5f2c995da70223a5bcb 100644 (file)
                        };
                };
 
-               spi_pins: spi {
-                       spi {
+               spi_pins: spi_pins {
+                       spi_pins {
                                ralink,group = "spi";
                                ralink,function = "spi";
                        };
                        };
                };
 
-               i2c_pins: i2c {
-                       i2c {
+               i2c_pins: i2c_pins {
+                       i2c_pins {
                                ralink,group = "i2c";
                                ralink,function = "i2c";
                        };
index 7fa15a6cefeb3ea8f7ba67c2e97f024d91a40014..54370a0c759c21ea495204431ab6a370bbe0ee44 100644 (file)
                        };
                };
 
-               spi_pins: spi {
-                       spi {
+               spi_pins: spi_pins {
+                       spi_pins {
                                ralink,group = "spi";
                                ralink,function = "spi";
                        };
                        };
                };
 
-               i2c_pins: i2c {
-                       i2c {
+               i2c_pins: i2c_pins {
+                       i2c_pins {
                                ralink,group = "i2c";
                                ralink,function = "i2c";
                        };
index 97a28cb10f0c4e5a1624e5c7f8c492cb5802be18..00b370effd1beb43098ad6a7511e66efc7c52323 100644 (file)
                state_default: pinctrl0 {
                };
 
-               i2c_pins: i2c {
-                       i2c {
+               i2c_pins: i2c_pins {
+                       i2c_pins {
                                ralink,group = "i2c";
                                ralink,function = "i2c";
                        };
                };
 
-               spi_pins: spi {
-                       spi {
+               spi_pins: spi_pins {
+                       spi_pins {
                                ralink,group = "spi";
                                ralink,function = "spi";
                        };
index b8a8bb910334cd9ba86b4b69ad2702e772fe4768..91f715c2457a7301f8565c103656dc068e11e9bd 100644 (file)
                state_default: pinctrl0 {
                };
 
-               spi_pins: spi {
-                       spi {
+               spi_pins: spi_pins {
+                       spi_pins {
                                ralink,group = "spi";
                                ralink,function = "spi";
                        };
                        };
                };
 
-               i2c_pins: i2c {
-                       i2c {
+               i2c_pins: i2c_pins {
+                       i2c_pins {
                                ralink,group = "i2c";
                                ralink,function = "i2c";
                        };
index c163657eda95031f115764fecf83af895b2e221c..762fe49e7c3a34a81ab9bbc575e23a82a170cbdd 100644 (file)
                        };
                };
 
-               i2c_pins: i2c {
-                       i2c {
+               i2c_pins: i2c_pins {
+                       i2c_pins {
                                ralink,group = "i2c";
                                ralink,function = "i2c";
                        };
                };
 
-               spi_pins: spi {
-                       spi {
+               spi_pins: spi_pins {
+                       spi_pins {
                                ralink,group = "spi";
                                ralink,function = "spi";
                        };
index 40b1b2126c71df6d7a71c228b12c62c0a11e0c00..84ddb061e6abc8db76e19f826072a14ffeaac533 100644 (file)
                        };
                };
 
-               i2c_pins: i2c {
-                       i2c {
+               i2c_pins: i2c_pins {
+                       i2c_pins {
                                ralink,group = "i2c";
                                ralink,function = "i2c";
                        };
                };
 
-               spi_pins: spi {
-                       spi {
+               spi_pins: spi_pins {
+                       spi_pins {
                                ralink,group = "spi";
                                ralink,function = "spi";
                        };
index 547de2cb4c1fe813ae5de478350ad64b70b752cc..548a6bb84ae02c81ac494d6d79f906577a86a439 100644 (file)
                state_default: pinctrl0 {
                };
 
-               i2c_pins: i2c {
-                       i2c {
+               i2c_pins: i2c_pins {
+                       i2c_pins {
                                ralink,group = "i2c";
                                ralink,function = "i2c";
                        };
                        };
                };
 
-               spi_pins: spi {
-                       spi {
+               spi_pins: spi_pins {
+                       spi_pins {
                                ralink,group = "spi";
                                ralink,function = "spi";
                        };
index 599b3723e972f5d1509d2a0284d44be31e1e0e7b..fffac169113fd48d51cf8e0e8ea6d1751b61db69 100644 (file)
                state_default: pinctrl0 {
                };
 
-               i2c_pins: i2c {
-                       i2c {
+               i2c_pins: i2c_pins {
+                       i2c_pins {
                                ralink,group = "i2c";
                                ralink,function = "i2c";
                        };
                };
 
-               spi_pins: spi {
-                       spi {
+               spi_pins: spi_pins {
+                       spi_pins {
                                ralink,group = "spi";
                                ralink,function = "spi";
                        };
index 1cc35f12a3750cabb2ac3ea1ca0dfdbbb39b3983..10ccc52cdcf8468ff7165f51d3871043db930ae8 100644 (file)
                state_default: pinctrl0 {
                };
 
-               i2c_pins: i2c {
-                       i2c {
+               i2c_pins: i2c_pins {
+                       i2c_pins {
                                ralink,group = "i2c";
                                ralink,function = "i2c";
                        };
                };
 
-               spi_pins: spi {
-                       spi {
+               spi_pins: spi_pins {
+                       spi_pins {
                                ralink,group = "spi";
                                ralink,function = "spi";
                        };