projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
949db15
)
x86/boot: Fix minor fd leakage in tools/relocs.c
author
Cong Ding
<dinggnu@gmail.com>
Mon, 14 Jan 2013 17:13:35 +0000
(17:13 +0000)
committer
H. Peter Anvin
<hpa@linux.intel.com>
Sun, 27 Jan 2013 18:24:28 +0000
(10:24 -0800)
The opened file should be closed.
Signed-off-by: Cong Ding <dinggnu@gmail.com>
Cc: Kusanagi Kouichi <slash@ac.auone-net.jp>
Cc: Jarkko Sakkinen <jarkko.sakkinen@intel.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Matt Fleming <matt.fleming@intel.com>
Link:
http://lkml.kernel.org/r/1358183628-27784-1-git-send-email-dinggnu@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/tools/relocs.c
patch
|
blob
|
history
diff --git
a/arch/x86/tools/relocs.c
b/arch/x86/tools/relocs.c
index 5a1847d619306e5f0ed5ed5570c53c69a8ce2315..79d67bd507fa6c5bd779defa312943b1d99a47f6 100644
(file)
--- a/
arch/x86/tools/relocs.c
+++ b/
arch/x86/tools/relocs.c
@@
-814,12
+814,14
@@
int main(int argc, char **argv)
read_relocs(fp);
if (show_absolute_syms) {
print_absolute_symbols();
-
return 0
;
+
goto out
;
}
if (show_absolute_relocs) {
print_absolute_relocs();
-
return 0
;
+
goto out
;
}
emit_relocs(as_text, use_real_mode);
+out:
+ fclose(fp);
return 0;
}