staging: qlge: emit debug and dump at same level
authorKaaira Gupta <kgupta@es.iitr.ac.in>
Sun, 23 Feb 2020 17:31:32 +0000 (23:01 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 23 Feb 2020 18:18:54 +0000 (19:18 +0100)
Simplify code in ql_mpi_core_to_log() by calling print_hex_dump()
instead of existing functions so that the debug and dump are
emitted at the same KERN_<LEVEL>

Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
Link: https://lore.kernel.org/r/20200223173132.GA13649@kaaira-HP-Pavilion-Notebook
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/qlge/qlge_dbg.c

index c7af2548d119585e8769a07273002fdcdb4ae843..44fb3a317b8dcb2b4c49187d5eaaaebccca0a501 100644 (file)
@@ -1324,27 +1324,10 @@ void ql_mpi_core_to_log(struct work_struct *work)
 {
        struct ql_adapter *qdev =
                container_of(work, struct ql_adapter, mpi_core_to_log.work);
-       u32 *tmp, count;
-       int i;
 
-       count = sizeof(struct ql_mpi_coredump) / sizeof(u32);
-       tmp = (u32 *)qdev->mpi_coredump;
-       netif_printk(qdev, drv, KERN_DEBUG, qdev->ndev,
-                    "Core is dumping to log file!\n");
-
-       for (i = 0; i < count; i += 8) {
-               pr_err("%.08x: %.08x %.08x %.08x %.08x %.08x "
-                       "%.08x %.08x %.08x\n", i,
-                       tmp[i + 0],
-                       tmp[i + 1],
-                       tmp[i + 2],
-                       tmp[i + 3],
-                       tmp[i + 4],
-                       tmp[i + 5],
-                       tmp[i + 6],
-                       tmp[i + 7]);
-               msleep(5);
-       }
+       print_hex_dump(KERN_DEBUG, "Core is dumping to log file!\n",
+                      DUMP_PREFIX_OFFSET, 32, 4, qdev->mpi_coredump,
+                      sizeof(*qdev->mpi_coredump), false);
 }
 
 #ifdef QL_REG_DUMP