mtd: maps: physmap: Store gpio_values correctly
authorChris Packham <chris.packham@alliedtelesis.co.nz>
Fri, 29 Mar 2019 02:13:21 +0000 (15:13 +1300)
committerRichard Weinberger <richard@nod.at>
Mon, 6 May 2019 19:46:45 +0000 (21:46 +0200)
When the gpio-addr-flash.c driver was merged with physmap-core.c the
code to store the current gpio_values was lost. This meant that once a
gpio was asserted it was never de-asserted. Fix this by storing the
current offset in gpio_values like the old driver used to.

Fixes: commit ba32ce95cbd9 ("mtd: maps: Merge gpio-addr-flash.c into physmap-core.c")
Cc: <stable@vger.kernel.org>
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
drivers/mtd/maps/physmap-core.c

index d9a3e4bebe5d8b94fea7fe983fc2db405dd729ae..21b556afc30504709b5d38552068bdf4981dadca 100644 (file)
@@ -132,6 +132,8 @@ static void physmap_set_addr_gpios(struct physmap_flash_info *info,
 
                gpiod_set_value(info->gpios->desc[i], !!(BIT(i) & ofs));
        }
+
+       info->gpio_values = ofs;
 }
 
 #define win_mask(order)                (BIT(order) - 1)