net: phy: Fix return value check in xgmiitorgmii_probe()
authorWei Yongjun <weiyj.lk@gmail.com>
Mon, 15 Aug 2016 22:34:57 +0000 (22:34 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Aug 2016 23:16:10 +0000 (16:16 -0700)
In case of error, the function of_parse_phandle() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/xilinx_gmii2rgmii.c

index 8e980ad476a4c0c22b93181cd30ddc5b2708c335..cad6e19724e2aa8aa8d78603becf3dabb278dab4 100644 (file)
@@ -67,7 +67,7 @@ int xgmiitorgmii_probe(struct mdio_device *mdiodev)
                return -ENOMEM;
 
        phy_node = of_parse_phandle(np, "phy-handle", 0);
-       if (IS_ERR(phy_node)) {
+       if (!phy_node) {
                dev_err(dev, "Couldn't parse phy-handle\n");
                return -ENODEV;
        }