Atari keyboard: incorporate additional review comments
authorGeert Uytterhoeven <geert@linux-m68k.org>
Mon, 15 Oct 2007 19:51:10 +0000 (21:51 +0200)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Mon, 15 Oct 2007 20:08:55 +0000 (13:08 -0700)
Atari keyboard: incorporate additional review comments:
  o Kill reference to source file name
  o Return error value from input_register_device() instead of -ENOMEM

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Michael Schmitz <schmitz@biophys.uni-duesseldorf.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/m68k/atari/atakeyb.c
drivers/input/keyboard/atakbd.c

index fbbccb5e75117a22967bbbeadc62e3e3c8a3c6dc..880add120eb3208715cb51a82bbd286ccbed877b 100644 (file)
@@ -1,6 +1,4 @@
 /*
- * linux/arch/m68k/atari/atakeyb.c
- *
  * Atari Keyboard driver for 680x0 Linux
  *
  * This file is subject to the terms and conditions of the GNU General Public
index f948d3a14a930383b9d2afeb78c09393114a07a7..a1800151b6ce8dc045005138154b065055afe171 100644 (file)
@@ -217,7 +217,7 @@ static void atakbd_interrupt(unsigned char scancode, char down)
 
 static int __init atakbd_init(void)
 {
-       int i;
+       int i, error;
 
        if (!MACH_IS_ATARI || !ATARIHW_PRESENT(ST_MFP))
                return -EIO;
@@ -247,9 +247,10 @@ static int __init atakbd_init(void)
        }
 
        /* error check */
-       if (input_register_device(atakbd_dev)) {
+       error = input_register_device(atakbd_dev);
+       if (error) {
                input_free_device(atakbd_dev);
-               return -ENOMEM;
+               return error;
        }
 
        atari_input_keyboard_interrupt_hook = atakbd_interrupt;