net/tls: byte swap device req TCP seq no upon setting

To avoid a sparse warning byteswap the be32 sequence number
before it's stored in the atomic value.  While at it drop
unnecessary brackets and use kernel's u64 type.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/include/net/tls.h b/include/net/tls.h
index 41a2ee643fc5dfd75630512ba6f545dfe327e613..39ea62f0c1f6aef57a3cef401b55959a5ac30f85 100644 (file)
--- a/include/net/tls.h
+++ b/include/net/tls.h
@@ -562,7 +562,7 @@ static inline void tls_offload_rx_resync_request(struct sock *sk, __be32 seq)
        struct tls_context *tls_ctx = tls_get_ctx(sk);
        struct tls_offload_context_rx *rx_ctx = tls_offload_ctx_rx(tls_ctx);
 
-       atomic64_set(&rx_ctx->resync_req, ((((uint64_t)seq) << 32) | 1));
+       atomic64_set(&rx_ctx->resync_req, ((u64)ntohl(seq) << 32) | 1);
 }
 
 

diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
index 79475b102cca4f396cb5ace398ba2abe26cac166..26f26e71ef3f6702d35806edf5a74bc5cc18b22d 100644 (file)
--- a/net/tls/tls_device.c
+++ b/net/tls/tls_device.c
@@ -567,7 +567,7 @@ void handle_device_resync(struct sock *sk, u32 seq, u64 rcd_sn)
 
        rx_ctx = tls_offload_ctx_rx(tls_ctx);
        resync_req = atomic64_read(&rx_ctx->resync_req);
-       req_seq = ntohl(resync_req >> 32) - ((u32)TLS_HEADER_SIZE - 1);
+       req_seq = (resync_req >> 32) - ((u32)TLS_HEADER_SIZE - 1);
        is_req_pending = resync_req;
 
        if (unlikely(is_req_pending) && req_seq == seq &&