usb: dwc3: omap: Remove explicit writes to SYSCONFIG register
authorKishon Vijay Abraham I <kishon@ti.com>
Fri, 25 Jan 2013 03:00:48 +0000 (08:30 +0530)
committerFelipe Balbi <balbi@ti.com>
Fri, 25 Jan 2013 07:16:57 +0000 (09:16 +0200)
The runtime API's takes care of setting the SYSCONFIG register with
appropriate values. Hence explicit writes to SYSCONFIG register is
removed.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/dwc3/dwc3-omap.c

index 80942301893cee5619f143cb268c11b207af86d8..f85ae5e6129d6fab006cb8f27656df56a3194c7e 100644 (file)
 
 /* SYSCONFIG REGISTER */
 #define USBOTGSS_SYSCONFIG_DMADISABLE          (1 << 16)
-#define USBOTGSS_SYSCONFIG_STANDBYMODE(x)      ((x) << 4)
-
-#define USBOTGSS_STANDBYMODE_FORCE_STANDBY     0
-#define USBOTGSS_STANDBYMODE_NO_STANDBY                1
-#define USBOTGSS_STANDBYMODE_SMART_STANDBY     2
-#define USBOTGSS_STANDBYMODE_SMART_WAKEUP      3
-
-#define USBOTGSS_STANDBYMODE_MASK              (0x03 << 4)
-
-#define USBOTGSS_SYSCONFIG_IDLEMODE(x)         ((x) << 2)
-
-#define USBOTGSS_IDLEMODE_FORCE_IDLE           0
-#define USBOTGSS_IDLEMODE_NO_IDLE              1
-#define USBOTGSS_IDLEMODE_SMART_IDLE           2
-#define USBOTGSS_IDLEMODE_SMART_WAKEUP         3
-
-#define USBOTGSS_IDLEMODE_MASK                 (0x03 << 2)
 
 /* IRQ_EOI REGISTER */
 #define USBOTGSS_IRQ_EOI_LINE_NUMBER           (1 << 0)
@@ -373,15 +356,6 @@ static int dwc3_omap_probe(struct platform_device *pdev)
        reg = dwc3_omap_readl(omap->base, USBOTGSS_SYSCONFIG);
        omap->dma_status = !!(reg & USBOTGSS_SYSCONFIG_DMADISABLE);
 
-       /* Set No-Idle and No-Standby */
-       reg &= ~(USBOTGSS_STANDBYMODE_MASK
-                       | USBOTGSS_IDLEMODE_MASK);
-
-       reg |= (USBOTGSS_SYSCONFIG_STANDBYMODE(USBOTGSS_STANDBYMODE_NO_STANDBY)
-               | USBOTGSS_SYSCONFIG_IDLEMODE(USBOTGSS_IDLEMODE_NO_IDLE));
-
-       dwc3_omap_writel(omap->base, USBOTGSS_SYSCONFIG, reg);
-
        ret = devm_request_irq(dev, omap->irq, dwc3_omap_interrupt, 0,
                        "dwc3-omap", omap);
        if (ret) {