rt2x00: Fix stuck queue in tx failure case
authorHelmut Schaa <helmut.schaa@googlemail.com>
Mon, 18 Apr 2011 13:26:37 +0000 (15:26 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 19 Apr 2011 19:39:09 +0000 (15:39 -0400)
Since commit 0b7fde54f94979edc67bbf86b5adba702ebfefe8 "rt2x00: Protect
queue control with mutex" rt2x00 used rt2x00queue_pause_queue for
stopping a tx queue in mac80211. But in case of a failure in the tx
path rt2x00 still called ieee80211_stop_queue which stopped the queue
but prevented rt2x00queue_unpause_queue to wake the queue up again
resulting in a stuck tx queue.

Fix this by also using rt2x00queue_pause_queue in case of tx failures.

Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rt2x00/rt2x00mac.c

index 661c6baad2b9bd7005c9d9bee9589d10486f9a0a..4a1c41b59fea2e7d090e6abf9f8c5ab592a73a52 100644 (file)
@@ -158,7 +158,7 @@ void rt2x00mac_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
        return;
 
  exit_fail:
-       ieee80211_stop_queue(rt2x00dev->hw, qid);
+       rt2x00queue_pause_queue(queue);
        dev_kfree_skb_any(skb);
 }
 EXPORT_SYMBOL_GPL(rt2x00mac_tx);