dns: remove redundant zero length namelen check
authorColin Ian King <colin.king@canonical.com>
Tue, 9 Apr 2019 12:59:12 +0000 (13:59 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 11 Apr 2019 21:01:08 +0000 (14:01 -0700)
The zero namelen check is redundant as it has already been checked
for zero at the start of the function.  Remove the redundant check.

Addresses-Coverity: ("Logically Dead Code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dns_resolver/dns_query.c

index 76338c38738a748aeaa899ebf30247c0f69741a8..19aa32fc1802b44a971eecd6f7b9f967ec2900d9 100644 (file)
@@ -94,8 +94,6 @@ int dns_query(const char *type, const char *name, size_t namelen,
                desclen += typelen + 1;
        }
 
-       if (!namelen)
-               namelen = strnlen(name, 256);
        if (namelen < 3 || namelen > 255)
                return -EINVAL;
        desclen += namelen + 1;