staging: comedi: dyna_pci10xx: Set number of AO channels to 1
authorIan Abbott <abbotti@mev.co.uk>
Tue, 16 Apr 2019 13:37:48 +0000 (14:37 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Apr 2019 10:40:51 +0000 (12:40 +0200)
The "dyna_pci10xx" driver supports the Dynalog India PCI-1050.  There
seems to be very little online information available about this card,
but as far as I can tell[*], it only has 1 AO (analog output) channel,
not 16 AO channels as reported in the Comedi subdevice information.
Besides, the Comedi "insn_write" handler for the AO subdevice takes no
account of channel numbers.  Change the `n_chans` member of the AO
subdevice structure to 1 to reflect this.

[*] The card is no longer mentioned on the manufacturer's web-site and I
couldn't find any archived page for the site on archive.org.  I found
part of a scientific paper which describes the card as having a single
channel D/A converter:
<http://shodhganga.inflibnet.ac.in/bitstream/10603/150646/15/15_chapter%205.pdf>.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/dyna_pci10xx.c

index 08c7e8eba28527c35d79f68a6a9a0c1abdb54b8f..c224422bb1269bfc4c5c9a27625acc15aaa60da0 100644 (file)
@@ -196,7 +196,7 @@ static int dyna_pci10xx_auto_attach(struct comedi_device *dev,
        s = &dev->subdevices[1];
        s->type = COMEDI_SUBD_AO;
        s->subdev_flags = SDF_WRITABLE;
-       s->n_chan = 16;
+       s->n_chan = 1;
        s->maxdata = 0x0FFF;
        s->range_table = &range_unipolar10;
        s->insn_write = dyna_pci10xx_insn_write_ao;