pkt_sched: Fix qdisc len in qdisc_peek_dequeued()
authorJarek Poplawski <jarkao2@gmail.com>
Thu, 6 Nov 2008 00:02:34 +0000 (16:02 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Nov 2008 00:02:34 +0000 (16:02 -0800)
A packet dequeued and stored as gso_skb in qdisc_peek_dequeued() should
be seen as part of the queue for sch->q.qlen queries until it's really
dequeued with qdisc_dequeue_peeked(), so qlen needs additional updating
in these functions. (Updating qstats.backlog shouldn't matter here.)

Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/sch_generic.h

index 9dcb5bfe094a3c6b833f253c1e04cba17c3d89ae..64ae1ba9f5544db72f058080e93aab5e76d84d77 100644 (file)
@@ -442,8 +442,12 @@ static inline struct sk_buff *qdisc_peek_head(struct Qdisc *sch)
 static inline struct sk_buff *qdisc_peek_dequeued(struct Qdisc *sch)
 {
        /* we can reuse ->gso_skb because peek isn't called for root qdiscs */
-       if (!sch->gso_skb)
+       if (!sch->gso_skb) {
                sch->gso_skb = sch->dequeue(sch);
+               if (sch->gso_skb)
+                       /* it's still part of the queue */
+                       sch->q.qlen++;
+       }
 
        return sch->gso_skb;
 }
@@ -453,10 +457,12 @@ static inline struct sk_buff *qdisc_dequeue_peeked(struct Qdisc *sch)
 {
        struct sk_buff *skb = sch->gso_skb;
 
-       if (skb)
+       if (skb) {
                sch->gso_skb = NULL;
-       else
+               sch->q.qlen--;
+       } else {
                skb = sch->dequeue(sch);
+       }
 
        return skb;
 }