drm/amdgpu/virt: fix double kfree on bo_va
authorColin Ian King <colin.king@canonical.com>
Fri, 3 Feb 2017 20:23:42 +0000 (20:23 +0000)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 9 Feb 2017 02:06:00 +0000 (21:06 -0500)
bo_va is being kfree'd twice, once in the call to amdgpu_vm_bo_rmv
and then a short while later. Fix this double free by removing
the 2nd kfree.

Detected by CoverityScan, CID#1399524 ("Double Free")

Reviewed-by: Monk Liu <monk.liu@amd.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c

index 3fd951c71d1b8563d6a2d2fd4cdf15c6faf15db2..dcfb7df3caf41d811916e155ee876c84ad4df271 100644 (file)
@@ -83,7 +83,6 @@ int amdgpu_map_static_csa(struct amdgpu_device *adev, struct amdgpu_vm *vm)
                DRM_ERROR("failed to do bo_map on static CSA, err=%d\n", r);
                amdgpu_vm_bo_rmv(adev, bo_va);
                ttm_eu_backoff_reservation(&ticket, &list);
-               kfree(bo_va);
                return r;
        }