drm/nouveau: Remove duplicate poll_enable() in pmops_runtime_suspend()
authorLyude Paul <lyude@redhat.com>
Wed, 15 Aug 2018 19:00:12 +0000 (15:00 -0400)
committerBen Skeggs <bskeggs@redhat.com>
Thu, 6 Sep 2018 20:54:26 +0000 (06:54 +1000)
Since actual hotplug notifications don't get disabled until
nouveau_display_fini() is called, all this will do is cause any hotplugs
that happen between this drm_kms_helper_poll_disable() call and the
actual hotplug disablement to potentially be dropped if ACPI isn't
around to help us.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Acked-by: Karol Herbst <kherbst@redhat.com>
Acked-by: Daniel Vetter <daniel@ffwll.ch>
Cc: stable@vger.kernel.org
Cc: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
drivers/gpu/drm/nouveau/nouveau_drm.c

index c7ec86d6c3c910fdb73a7774eb921a414c156363..5fdc1fbe2ee5a8643267ee6d4f4055ad934219e0 100644 (file)
@@ -835,7 +835,6 @@ nouveau_pmops_runtime_suspend(struct device *dev)
                return -EBUSY;
        }
 
-       drm_kms_helper_poll_disable(drm_dev);
        nouveau_switcheroo_optimus_dsm();
        ret = nouveau_do_suspend(drm_dev, true);
        pci_save_state(pdev);