net: macb: add missed tasklet_kill
authorChuhong Yuan <hslester96@gmail.com>
Thu, 28 Nov 2019 02:00:21 +0000 (10:00 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 29 Nov 2019 07:05:28 +0000 (23:05 -0800)
This driver forgets to kill tasklet in remove.
Add the call to fix it.

Fixes: 032dc41ba6e2 ("net: macb: Handle HRESP error")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cadence/macb_main.c

index d5ae2e1e0b0e249d305cb10d1c69abba8f16be45..9c767ee252acc53e47fd0f093d17ea7e1670d43a 100644 (file)
@@ -4422,6 +4422,7 @@ static int macb_remove(struct platform_device *pdev)
                mdiobus_free(bp->mii_bus);
 
                unregister_netdev(dev);
+               tasklet_kill(&bp->hresp_err_tasklet);
                pm_runtime_disable(&pdev->dev);
                pm_runtime_dont_use_autosuspend(&pdev->dev);
                if (!pm_runtime_suspended(&pdev->dev)) {