net: hns3: modify the upper limit judgment condition
authorliuzhongzhu <liuzhongzhu@huawei.com>
Sat, 2 Feb 2019 14:39:36 +0000 (22:39 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 2 Feb 2019 16:24:09 +0000 (08:24 -0800)
In order to prevent the variable anomaly from being larger than desc_num,
the upper limit judgment condition becomes >=.

Signed-off-by: liuzhongzhu <liuzhongzhu@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c

index 57c50b947857753c7ebca85d20b9cd2b58804db3..1dddfcba41a9e3889db51d440a67abd47fc5a186 100644 (file)
@@ -197,7 +197,7 @@ static int hclge_cmd_check_retval(struct hclge_hw *hw, struct hclge_desc *desc,
        for (handle = 0; handle < num; handle++) {
                desc[handle] = hw->cmq.csq.desc[ntc];
                ntc++;
-               if (ntc == hw->cmq.csq.desc_num)
+               if (ntc >= hw->cmq.csq.desc_num)
                        ntc = 0;
        }
        if (likely(!hclge_is_special_opcode(opcode)))
@@ -254,7 +254,7 @@ int hclge_cmd_send(struct hclge_hw *hw, struct hclge_desc *desc, int num)
                desc_to_use = &hw->cmq.csq.desc[hw->cmq.csq.next_to_use];
                *desc_to_use = desc[handle];
                (hw->cmq.csq.next_to_use)++;
-               if (hw->cmq.csq.next_to_use == hw->cmq.csq.desc_num)
+               if (hw->cmq.csq.next_to_use >= hw->cmq.csq.desc_num)
                        hw->cmq.csq.next_to_use = 0;
                handle++;
        }