scsi: ufs: remove unnecessary pointer evaluation
authorZeng Guangyue <zengguangyue@hisilicon.com>
Sat, 30 Mar 2019 09:03:13 +0000 (17:03 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 4 Apr 2019 03:45:59 +0000 (23:45 -0400)
The pointer value is initialized as &hba->vreg_info, and it's never
changed. It's not necessary to check the pointer is null or not.

Signed-off-by: Zeng Guangyue <zengguangyue@hisilicon.com>
Acked-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c

index 5ba49c8cd2a36e2c593a22810532e80059ec37c6..b9a3d6784abf6e2c20f65825d718e92d438c0dbe 100644 (file)
@@ -7115,9 +7115,6 @@ static int ufshcd_setup_vreg(struct ufs_hba *hba, bool on)
        struct device *dev = hba->dev;
        struct ufs_vreg_info *info = &hba->vreg_info;
 
-       if (!info)
-               goto out;
-
        ret = ufshcd_toggle_vreg(dev, info->vcc, on);
        if (ret)
                goto out;
@@ -7143,10 +7140,7 @@ static int ufshcd_setup_hba_vreg(struct ufs_hba *hba, bool on)
 {
        struct ufs_vreg_info *info = &hba->vreg_info;
 
-       if (info)
-               return ufshcd_toggle_vreg(hba->dev, info->vdd_hba, on);
-
-       return 0;
+       return ufshcd_toggle_vreg(hba->dev, info->vdd_hba, on);
 }
 
 static int ufshcd_get_vreg(struct device *dev, struct ufs_vreg *vreg)
@@ -7172,9 +7166,6 @@ static int ufshcd_init_vreg(struct ufs_hba *hba)
        struct device *dev = hba->dev;
        struct ufs_vreg_info *info = &hba->vreg_info;
 
-       if (!info)
-               goto out;
-
        ret = ufshcd_get_vreg(dev, info->vcc);
        if (ret)
                goto out;