crypto: talitos - fix size calculation in talitos_edesc_alloc()

The + operation has higher precedence than ?: so we need parentheses
here.  Otherwise we may end up allocating a max of only one "cryptlen"
instead of two.

Fixes: 6f65f6ac5fb3 ('crypto: talitos - implement scatter/gather copy for SEC1')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Christophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
index 4c0778b03de655f571a6716991a362f3ef437684..aaa7af856b39890be1b2b2ba9a5fb178bb5fb171 100644 (file)
--- a/drivers/crypto/talitos.c
+++ b/drivers/crypto/talitos.c
@@ -1335,8 +1335,8 @@ static struct talitos_edesc *talitos_edesc_alloc(struct device *dev,
        alloc_len = sizeof(struct talitos_edesc);
        if (assoc_nents || src_nents || dst_nents) {
                if (is_sec1)
-                       dma_len = src_nents ? cryptlen : 0 +
-                                 dst_nents ? cryptlen : 0;
+                       dma_len = (src_nents ? cryptlen : 0) +
+                                 (dst_nents ? cryptlen : 0);
                else
                        dma_len = (src_nents + dst_nents + 2 + assoc_nents) *
                                  sizeof(struct talitos_ptr) + authsize;