vxge: Removed the code to bounds check the mss value
authorSreenivasa Honnur <Sreenivasa.Honnur@neterion.com>
Wed, 1 Jul 2009 21:15:41 +0000 (21:15 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 6 Jul 2009 02:16:32 +0000 (19:16 -0700)
- Removed the code to bounds check the mss value. The hardware does bounds checking and
will not allow an oversized mss to lockup the transmit path.

Signed-off-by: Sreenivasa Honnur <sreenivasa.honnur@neterion.com>
Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vxge/vxge-main.c
drivers/net/vxge/vxge-traffic.h

index dd2add1d7566c460599222ef157e8b0105ca5521..cda18f815c3a54f9ed7a9aec4210163cd1b6058e 100644 (file)
@@ -817,7 +817,6 @@ vxge_xmit(struct sk_buff *skb, struct net_device *dev)
        u64 dma_pointer;
        struct vxge_tx_priv *txdl_priv = NULL;
        struct __vxge_hw_fifo *fifo_hw;
-       u32 max_mss = 0x0;
        int offload_type;
        unsigned long flags = 0;
        int vpath_no = 0;
@@ -969,10 +968,6 @@ vxge_xmit(struct sk_buff *skb, struct net_device *dev)
 
                int mss = vxge_tcp_mss(skb);
                if (mss) {
-                       max_mss = dev->mtu + ETH_HLEN -
-                               VXGE_HW_TCPIP_HEADER_MAX_SIZE;
-                       if (mss > max_mss)
-                               mss = max_mss;
                        vxge_debug_tx(VXGE_TRACE,
                                "%s: %s:%d mss = %d",
                                dev->name, __func__, __LINE__, mss);
index 7567a1140d073bf700100c1893ff1273826cd1e0..8260b91fd79515605df1a36c6a8df85273831a0e 100644 (file)
@@ -35,8 +35,6 @@
                        VXGE_HW_HEADER_VLAN_SIZE + \
                        VXGE_HW_HEADER_SNAP_SIZE)
 
-#define VXGE_HW_TCPIP_HEADER_MAX_SIZE  (64 + 64)
-
 /* 32bit alignments */
 #define VXGE_HW_HEADER_ETHERNET_II_802_3_ALIGN         2
 #define VXGE_HW_HEADER_802_2_SNAP_ALIGN                        2