ptp: idt82p33: remove unnecessary comparison
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 24 Apr 2020 08:03:48 +0000 (16:03 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 24 Apr 2020 23:59:21 +0000 (16:59 -0700)
The type of loaddr is u8 which is always '<=' 0xff, so the
loaddr <= 0xff is always true, we can remove this comparison.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/ptp/ptp_idt82p33.c

index 31ea811b6d5f2d37986ec30b58a53468a18ca635..179f6c472e5006265e639350fe493fe941dfdce4 100644 (file)
@@ -881,7 +881,7 @@ static int idt82p33_load_firmware(struct idt82p33 *idt82p33)
 
                        /* Page size 128, last 4 bytes of page skipped */
                        if (((loaddr > 0x7b) && (loaddr <= 0x7f))
-                            || ((loaddr > 0xfb) && (loaddr <= 0xff)))
+                            || loaddr > 0xfb)
                                continue;
 
                        err = idt82p33_write(idt82p33, _ADDR(page, loaddr),