staging: sm750fb: change definition of PANEL_VERTICAL_TOTAL fields
authorMike Rapoport <mike.rapoport@gmail.com>
Mon, 15 Feb 2016 17:53:52 +0000 (19:53 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 16 Feb 2016 02:26:17 +0000 (18:26 -0800)
Use stratight-forward definition of PANEL_VERTICAL_TOTAL register fields
and use open-coded implementation for register manipulation

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/sm750fb/ddk750_mode.c
drivers/staging/sm750fb/ddk750_reg.h

index 4394ad1ff154643165227bb7cbff2b1745ff3587..7c4f3fba0e8034e70965d6c7003b821aca57dd35 100644 (file)
@@ -148,8 +148,11 @@ static int programModeRegisters(mode_parameter_t *pModeParam, pll_value_t *pll)
                                PANEL_HORIZONTAL_SYNC_START_MASK));
 
                POKE32(PANEL_VERTICAL_TOTAL,
-               FIELD_VALUE(0, PANEL_VERTICAL_TOTAL, TOTAL, pModeParam->vertical_total - 1)
-                       | FIELD_VALUE(0, PANEL_VERTICAL_TOTAL, DISPLAY_END, pModeParam->vertical_display_end - 1));
+                       (((pModeParam->vertical_total - 1) <<
+                               PANEL_VERTICAL_TOTAL_TOTAL_SHIFT) &
+                               PANEL_VERTICAL_TOTAL_TOTAL_MASK) |
+                       ((pModeParam->vertical_display_end - 1) &
+                               PANEL_VERTICAL_TOTAL_DISPLAY_END_MASK));
 
                POKE32(PANEL_VERTICAL_SYNC,
                FIELD_VALUE(0, PANEL_VERTICAL_SYNC, HEIGHT, pModeParam->vertical_sync_height)
index fd28eb0be68a0f2c1dbc10dfcae11591a4717217..0ecbac58f8fd8d35512b0787d3b0e0217982518e 100644 (file)
 #define PANEL_HORIZONTAL_SYNC_START_MASK              0xfff
 
 #define PANEL_VERTICAL_TOTAL                          0x08002C
-#define PANEL_VERTICAL_TOTAL_TOTAL                    26:16
-#define PANEL_VERTICAL_TOTAL_DISPLAY_END              10:0
+#define PANEL_VERTICAL_TOTAL_TOTAL_SHIFT              16
+#define PANEL_VERTICAL_TOTAL_TOTAL_MASK               (0x7ff << 16)
+#define PANEL_VERTICAL_TOTAL_DISPLAY_END_MASK         0x7ff
 
 #define PANEL_VERTICAL_SYNC                           0x080030
 #define PANEL_VERTICAL_SYNC_HEIGHT                    21:16