make_cert: return error when invalid options are used
authorRoberto Vargas <roberto.vargas@arm.com>
Wed, 27 Jun 2018 07:23:22 +0000 (08:23 +0100)
committerRoberto Vargas <roberto.vargas@arm.com>
Wed, 27 Jun 2018 07:25:20 +0000 (08:25 +0100)
Print_help was used in different contexts and returning no
error in that function was hiding the error when incorrect
options were used.

Change-Id: Ic3f71748be7ff8440c9d54810b986e9f177f4439
Signed-off-by: Roberto Vargas <roberto.vargas@arm.com>
tools/cert_create/src/main.c

index 4abfe6dd766ce3aa3d73506b699175bf34b0f970..ed566207cd6530ac9005d60175b2f07e67079180 100644 (file)
@@ -140,8 +140,6 @@ static void print_help(const char *cmd, const struct option *long_opt)
                i++;
        }
        printf("\n");
-
-       exit(0);
 }
 
 static int get_key_alg(const char *key_alg_str)
@@ -334,7 +332,7 @@ int main(int argc, char *argv[])
                        break;
                case 'h':
                        print_help(argv[0], cmd_opt);
-                       break;
+                       exit(0);
                case 'k':
                        save_keys = 1;
                        break;