aio: Skip timer for io_getevents if timeout=0
authorFam Zheng <famz@redhat.com>
Thu, 6 Nov 2014 12:44:36 +0000 (20:44 +0800)
committerBenjamin LaHaise <bcrl@kvack.org>
Sat, 13 Dec 2014 22:50:20 +0000 (17:50 -0500)
In this case, it is basically a polling. Let's not involve timer at all
because that would hurt performance for application event loops.

In an arbitrary test I've done, io_getevents syscall elapsed time
reduces from 50000+ nanoseconds to a few hundereds.

Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Benjamin LaHaise <bcrl@kvack.org>
fs/aio.c

index bfab55607a4d57f19964d667800f1492ba8ab04f..1b7893ecc29654f6d20cf420b24ee20dddbf9038 100644 (file)
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -1253,8 +1253,12 @@ static long read_events(struct kioctx *ctx, long min_nr, long nr,
         * the ringbuffer empty. So in practice we should be ok, but it's
         * something to be aware of when touching this code.
         */
-       wait_event_interruptible_hrtimeout(ctx->wait,
-                       aio_read_events(ctx, min_nr, nr, event, &ret), until);
+       if (until.tv64 == 0)
+               aio_read_events(ctx, min_nr, nr, event, &ret);
+       else
+               wait_event_interruptible_hrtimeout(ctx->wait,
+                               aio_read_events(ctx, min_nr, nr, event, &ret),
+                               until);
 
        if (!ret && signal_pending(current))
                ret = -EINTR;