Input: wdt87xx_i2c - use managed devm_device_add_group
authorAndi Shyti <andi@etezian.org>
Fri, 29 Sep 2017 23:40:25 +0000 (16:40 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 29 Sep 2017 23:51:05 +0000 (16:51 -0700)
Commit 57b8ff070f98 ("driver core: add devm_device_add_group() and
friends") has added the managed version for creating sysfs group files.

Use devm_device_add_group instead of sysfs_create_group and remove the
relative sysfs_remove_group.

Signed-off-by: Andi Shyti <andi@etezian.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/wdt87xx_i2c.c

index a9132603ab3498ecb7d380f2e18131e16fc03dc4..d351efd18f89c68d04101e10293e332205c2a32c 100644 (file)
@@ -1106,7 +1106,7 @@ static int wdt87xx_ts_probe(struct i2c_client *client,
                return error;
        }
 
-       error = sysfs_create_group(&client->dev.kobj, &wdt87xx_attr_group);
+       error = devm_device_add_group(&client->dev, &wdt87xx_attr_group);
        if (error) {
                dev_err(&client->dev, "create sysfs failed: %d\n", error);
                return error;
@@ -1115,13 +1115,6 @@ static int wdt87xx_ts_probe(struct i2c_client *client,
        return 0;
 }
 
-static int wdt87xx_ts_remove(struct i2c_client *client)
-{
-       sysfs_remove_group(&client->dev.kobj, &wdt87xx_attr_group);
-
-       return 0;
-}
-
 static int __maybe_unused wdt87xx_suspend(struct device *dev)
 {
        struct i2c_client *client = to_i2c_client(dev);
@@ -1179,7 +1172,6 @@ MODULE_DEVICE_TABLE(acpi, wdt87xx_acpi_id);
 
 static struct i2c_driver wdt87xx_driver = {
        .probe          = wdt87xx_ts_probe,
-       .remove         = wdt87xx_ts_remove,
        .id_table       = wdt87xx_dev_id,
        .driver = {
                .name   = WDT87XX_NAME,