projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
7ca7ec4
)
driver core: Delete an unnecessary check before the function call "put_device"
author
Markus Elfring
<elfring@users.sourceforge.net>
Thu, 5 Feb 2015 10:48:26 +0000
(11:48 +0100)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 25 Mar 2015 12:52:35 +0000
(13:52 +0100)
The put_device() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/core.c
patch
|
blob
|
history
diff --git
a/drivers/base/core.c
b/drivers/base/core.c
index 07304a3b9ee2872d85526cba24eabd422997aa7e..e0998b6b6c4938f0ef8e93b84e6507b8e3c61752 100644
(file)
--- a/
drivers/base/core.c
+++ b/
drivers/base/core.c
@@
-1095,8
+1095,7
@@
done:
kobject_del(&dev->kobj);
Error:
cleanup_device_parent(dev);
- if (parent)
- put_device(parent);
+ put_device(parent);
name_error:
kfree(dev->p);
dev->p = NULL;